ci: use shared gh-actions/actions/contract-tests action#164
Open
kinyoklion wants to merge 2 commits into
Open
Conversation
Replace the local .github/actions/contract-tests action with the shared launchdarkly/gh-actions/actions/contract-tests@contract-tests-v1 action. The local action accepted a token input but never forwarded it to the Makefile or curl commands, so the GITHUB_TOKEN was not used when downloading the contract test harness. The shared action properly passes the token both as an Authorization header and as the GITHUB_TOKEN env var to avoid rate limiting. The build and start steps are now explicit workflow steps since the shared action only handles downloading and running the harness. Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
N/A — CI-only change.
Describe the solution you've provided
Replace the local
.github/actions/contract-testsaction with the sharedlaunchdarkly/gh-actions/actions/contract-tests@contract-tests-v1action.The local action accepted a
tokeninput but never forwarded it, soGITHUB_TOKENwas not used when downloading the contract test harness (leading to potential rate limiting). The shared action properly passes the token both as anAuthorizationheader on the curl request and as theGITHUB_TOKENenv var for the downloader script.Since the shared action only handles downloading and running the harness (not building/starting the test service), the build and start steps are now explicit workflow steps.
Describe alternatives you've considered
Could have fixed the local action to forward the token to the Makefile, but using the shared action is more maintainable and consistent with other SDK repos.
Additional context
Both
java-server-sdk.ymlandnightly-contract-tests.ymlare updated. The Makefile is left unchanged so local development workflows still work."Link to Devin session: https://app.devin.ai/sessions/02984ba491764e598f041b70041206ba
Requested by: @kinyoklion
Note
Low Risk
CI-only workflow changes; no application runtime or SDK library behavior is modified.
Overview
Removes the repo-local contract-tests composite action and wires java-server-sdk and nightly-contract-tests workflows to
launchdarkly/gh-actions/actions/contract-tests@contract-tests-v1.Contract testing now explicitly runs
make build-contract-testsandmake start-contract-test-service-bgbefore the harness. v2 and v3 harness runs are separate steps (v3 pinned tov3.0.0-alpha.6), each passingGITHUB_TOKEN, suppression files viaextra_params, and shared options likeenable_persistence_tests: 'false'. Nightly v3 still passes-enable-long-running-teststhroughextra_params.Reviewed by Cursor Bugbot for commit 3580edb. Bugbot is set up for automated code reviews on this repo. Configure here.